This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix: Clear SearchBox without search as you type #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouss
changed the title
|
Deploy preview ready! Built with commit 4e6c72f |
Haroenv
approved these changes
Jan 5, 2018
samouss
force-pushed
the
fix/clear-searchbox-without-search-as-you-type
branch
2 times, most recently
from
15fa851 to
123eb15
Compare
samouss
force-pushed
the
fix/clear-searchbox-without-search-as-you-type
branch
from
123eb15 to
4e6c72f
Compare
samouss
added a commit
that referenced
this pull request
Jan 9, 2018
<a name="4.4.1"></a> ## [4.4.1](v4.4.0...v4.4.1) (2018-01-09) ### Bug Fixes * **SearchBox**: clear SearchBox without search as you type ([#802](#802)) ([c49b2b6](c49b2b6)) * **connectRange:** check if facet exist before access ([#797](#797)) ([6520760](6520760)) * **stories:** avoid to use linear-background it breaks Argos every time ([#804](#804)) ([0beded7](0beded7)) * **stories:** limit hits per page on Index ([#806](#806)) ([6eb14d3](6eb14d3)) ### Features * **Index:** allow custom root ([#792](#792)) ([d793b0a](d793b0a))
Haroenv
added a commit
that referenced
this pull request
Sep 29, 2022
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. --> **Summary** <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? Are there any linked issues? --> Similarly as #802, when reset is triggered and searchAsYouType is false, a search should still happen. **Result** fixes #3641 <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #799
When the button
resetis clicked the query should be clear. But it's only works when thesearchAsYouTypeistruesince we are using the same function for thereset&changeevent. Now we don't use the same function for both events.In a future refactoring we can probably avoid to handle the state of the query with two different cases (control & uncontrol). We could move for a full control input with a copy of the current refinement in the local state. It will avoid to have two sources of truth in the component.
Before
After
You can also play with the example on Storybook.