This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(connectRange): update default refinement propTypes #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouss
force-pushed
the
fix/connect-range-default-refinement
branch
from
26209f3 to
ee99dad
Compare
samouss
changed the title
|
Deploy preview for react-instantsearch ready! Built with commit e1304c0 |
samouss
force-pushed
the
fix/connect-range-default-refinement
branch
from
ee99dad to
0908610
Compare
samouss
force-pushed
the
fix/connect-range-default-refinement
branch
from
0908610 to
e1304c0
Compare
Haroenv
approved these changes
Feb 16, 2018
samouss
added a commit
that referenced
this pull request
Mar 6, 2018
<a name="4.5.2"></a> ## [4.5.2](v4.5.1...v4.5.2) (2018-03-06) ### Bug Fixes * **connectRange:** update default refinement propTypes ([#978](#978)) ([c065fb1](c065fb1)) * **IndexUtils:** avoid throw an error when cleanUp multi index ([#1019](#1019)) ([865a3c3](865a3c3)) * **SearchBox:** avoid to bind click on reset button ([#979](#979)) ([ea3063a](ea3063a))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #564
With the current implementation when we provide a
defaultRefinementtoconnectRangewe must pass an object with bothmin&max. There are some cases when we want to pass only a min, max or even an empty object. In the latter case it allow the widget to be "controlled" by thedefaultRefinement. See #892.