This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(SearchBox): avoid to bind click on reset button #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 31d9d74 |
samouss
force-pushed
the
fix/search-box-clear
branch
from
f41d180 to
31d9d74
Compare
samouss
added a commit
that referenced
this pull request
Mar 6, 2018
<a name="4.5.2"></a> ## [4.5.2](v4.5.1...v4.5.2) (2018-03-06) ### Bug Fixes * **connectRange:** update default refinement propTypes ([#978](#978)) ([c065fb1](c065fb1)) * **IndexUtils:** avoid throw an error when cleanUp multi index ([#1019](#1019)) ([865a3c3](865a3c3)) * **SearchBox:** avoid to bind click on reset button ([#979](#979)) ([ea3063a](ea3063a))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #926
In the current implementation we bind the form with a
onResethandler. But the reset button is also bound with the same callbackonClick. So when the form is clear by clicking on the button two events are triggered (and so two queries). The first is trigger by the form & the second one by the button.We don't need to bind the second handler on the reset button. Because the click will trigger the
resetevent on the form.Before:
After: