From 010e3ef2105fd092ffe6a00f4964d457477e6e47 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E7=8E=84=E9=A3=8F?= <yangzehua.yzh@alibaba-inc.com>
Date: Tue, 3 Dec 2024 14:44:09 +0800
Subject: [PATCH] polish

---
 .../metric_models/SelfMonitorMetricEvent.cpp        | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/core/monitor/metric_models/SelfMonitorMetricEvent.cpp b/core/monitor/metric_models/SelfMonitorMetricEvent.cpp
index 367163a400..e35698e359 100644
--- a/core/monitor/metric_models/SelfMonitorMetricEvent.cpp
+++ b/core/monitor/metric_models/SelfMonitorMetricEvent.cpp
@@ -67,8 +67,19 @@ SelfMonitorMetricEvent::SelfMonitorMetricEvent(const std::map<std::string, std::
     Json::Value labels, counters, gauges;
     string errMsg;
     ParseJsonTable(metricRecord.at(METRIC_GO_KEY_LABELS), labels, errMsg);
+    if (!errMsg.empty()) {
+        mCategory = MetricCategory::METRIC_CATEGORY_UNKNOWN;
+        LOG_ERROR(sLogger, ("parse go metric", "labels")("err", errMsg));
+        return;
+    }
     ParseJsonTable(metricRecord.at(METRIC_GO_KEY_COUNTERS), counters, errMsg);
+    if (!errMsg.empty()) {
+        LOG_ERROR(sLogger, ("parse go metric", "counters")("err", errMsg));
+    }
     ParseJsonTable(metricRecord.at(METRIC_GO_KEY_GAUGES), gauges, errMsg);
+    if (!errMsg.empty()) {
+        LOG_ERROR(sLogger, ("parse go metric", "gauges")("err", errMsg));
+    }
     // category
     if (labels.isMember("metric_category")) {
         mCategory = labels["metric_category"].asString();
@@ -88,7 +99,7 @@ SelfMonitorMetricEvent::SelfMonitorMetricEvent(const std::map<std::string, std::
         if (itr->isString()) {
             try {
                 mCounters[itr.key().asString()] = static_cast<uint64_t>(std::stod(itr->asString()));
-            } catch (...) {
+            } catch (...) { // catch std::invalid_argument & std::out_of_range
                 mCounters[itr.key().asString()] = 0;
             }
         }