fix: make container ID json name compatible #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
Codecov Report
@@ Coverage Diff @@
## master #1002 +/- ##
=======================================
Coverage 12.75% 12.75%
=======================================
Files 132 132
Lines 9032 9032
=======================================
Hits 1152 1152
Misses 7781 7781
Partials 99 99Continue to review full report at Codecov.
|
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
This PR has fixed an incompatible issue in the pouch's API.
When communicating between Pouch client and daemon, we use json type to transfer data. While to be more compatible with moby's API, we need to make the transfer all the same.
This fix some incompatibility.
Ⅱ. Does this pull request fix one issue?
this is related to #977
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none