Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: setup hook in advance to avoid panic if no prestart hook setup before #1038

Merged
merged 1 commit into from
Apr 7, 2018

Conversation

yyb196
Copy link
Collaborator

@yyb196 yyb196 commented Apr 3, 2018

Signed-off-by: Frank Yang yyb196@gmail.com

Ⅰ. Describe what this PR did

setup hook in advance to avoid panic if no prestart hook setup before this place

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/panic priority/P1 this is high priority that all maintainers should stop to handle this issue size/S labels Apr 3, 2018
@allencloud
Copy link
Collaborator

Could we add an integration test to cover this? @yyb196 @wangforthinker

@codecov-io
Copy link

Codecov Report

Merging #1038 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1038   +/-   ##
=======================================
  Coverage   15.71%   15.71%           
=======================================
  Files         139      139           
  Lines        8483     8483           
=======================================
  Hits         1333     1333           
  Misses       7050     7050           
  Partials      100      100
Impacted Files Coverage Δ
daemon/mgr/spec_hook.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c67ec...a6fc5c6. Read the comment docs.

@rudyfly
Copy link
Collaborator

rudyfly commented Apr 4, 2018

The title should be: "bugfix: setup hook in advance to avoid panic if no prestart hook setup before"

@allencloud allencloud changed the title setup hook in advance to avoid panic if no prestart hook setup before bugfix: setup hook in advance to avoid panic if no prestart hook setup before Apr 4, 2018
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Apr 4, 2018
@allencloud
Copy link
Collaborator

I changed the title. What do you think of this pull request?
I wish that you could help to review this, since this is a P0. @rudyfly

@HusterWan
Copy link
Contributor

LGTM

1 similar comment
@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 7, 2018
@allencloud allencloud merged commit 263f961 into AliyunContainerService:master Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project kind/panic LGTM one maintainer or community participant agrees to merge the pull reuqest. priority/P1 this is high priority that all maintainers should stop to handle this issue size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants