Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix misspell in docs #1200

Merged
merged 1 commit into from
Apr 25, 2018
Merged

docs: fix misspell in docs #1200

merged 1 commit into from
Apr 25, 2018

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR did

docs: fix misspell in docs

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @shaloulcy
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

HusterWan
HusterWan reviewed Apr 25, 2018
View reviewed changes
docs/kubernetes/pouch_with_cri_introduction.md
@@ -34,4 +34,4 @@ After these steps, a pod and its corresponding application container is created

This diagram briefly explains pouch CRI internal module workflow：

![CRI workflow](../static_files/pouch_whith_cri_work_flow.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static_files file name also need be fix

@shaloulcy
docs: fix misspell in docs
8b7d4e7 
Signed-off-by: Chuanyun Li <lcy041536@gmail.com>
@pouchrobot
Copy link
Collaborator

ping @shaloulcy

CI fails according integration system.
Please refer to the CI failure Details button to corresponding test, and update your PR to pass CI.

If this is flaky test, welcome to track this with profiling an issue.

build url: https://travis-ci.org/alibaba/pouch/builds/370866979
build duration: 194s

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 25, 2018
@HusterWan HusterWan merged commit 1632d81 into AliyunContainerService:master Apr 25, 2018
@pouchrobot pouchrobot mentioned this pull request Apr 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HusterWan HusterWan HusterWan left review comments

Assignees
No one assigned
Labels
areas/docs LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaloulcy @pouchrobot @CLAassistant @HusterWan