Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix TestRunWithPidsLimit fail cause no pids cgroup support #1353

Merged
merged 1 commit into from
May 18, 2018
Merged

Conversation

Ace-Tang
Copy link
Contributor

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

Some kernel not support pids cgroup that make test case TestRunWithPidsLimit fail

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Ace-Tang <aceapril@126.com>
@codecov-io
Copy link

Codecov Report

Merging #1353 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   17.34%   17.32%   -0.03%     
==========================================
  Files         189      189              
  Lines       11829    11822       -7     
==========================================
- Hits         2052     2048       -4     
+ Misses       9630     9627       -3     
  Partials      147      147
Impacted Files Coverage Δ
daemon/mgr/image_store.go 80.7% <0%> (-0.66%) ⬇️
daemon/mgr/volume.go 0% <0%> (ø) ⬆️
daemon/mgr/container.go 0% <0%> (ø) ⬆️
cri/src/cri.go 0% <0%> (ø) ⬆️
daemon/mgr/image.go 0% <0%> (ø) ⬆️

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 18, 2018
@allencloud allencloud merged commit 29bc6fa into AliyunContainerService:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants