bugfix: fix cgroup-parent can not set from config #1361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove initial value in cgroup-parent flag, or this flag
can never be set from config file when create container
with pouch cli.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
If pouch cli give cgroup-parent a default value, the
c.HostConfig.CgroupParent
will never be empty, and it can never useCgroupParent
set from daemon config file.The default cgroup parent we already set in
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews