Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feature: add pouch kill functionality" #1538

Merged

Conversation

xiechengsheng
Copy link
Contributor

Reverts #1485

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @xiechengsheng
While we thought PR Description could be more specific, longer than 100 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

@xiechengsheng Thanks for your contribution. 🍻
Please sign off in each of your commits.

@codecov-io
Copy link

Codecov Report

Merging #1538 into master will increase coverage by 23.98%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1538       +/-   ##
===========================================
+ Coverage   16.75%   40.73%   +23.98%     
===========================================
  Files         213      254       +41     
  Lines       14175    16643     +2468     
===========================================
+ Hits         2375     6780     +4405     
+ Misses      11637     8996     -2641     
- Partials      163      867      +704
Impacted Files Coverage Δ
daemon/mgr/container.go 48.88% <ø> (+48.88%) ⬆️
cli/main.go 0% <ø> (ø) ⬆️
apis/server/container_bridge.go 82.88% <ø> (+82.88%) ⬆️
apis/server/router.go 91.3% <ø> (+91.3%) ⬆️
ctrd/container.go 50.18% <ø> (+50.18%) ⬆️
storage/volume/driver/proxy.go 53.42% <0%> (ø)
storage/quota/grpquota.go 0% <0%> (ø)
pkg/jsonstream/format.go 80.95% <0%> (ø)
cri/stream/portforward/httpstream.go 0% <0%> (ø)
pkg/serializer/serialize.go 9.52% <0%> (ø)
... and 118 more

@allencloud
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants