Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: refine tests with specifying CMD #1548

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

Letty5411
Copy link
Contributor

Signed-off-by: letty letty.ll@alibaba-inc.com

Ⅰ. Describe what this PR did

Add "top" CMD when running a container. If we don't specify CMD when starting a container, it will use the default one in image, most of time it is sh. Sometimes, test may expect the container in running state, which is not true if CMD is not specified explicitly.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@allencloud
Copy link
Collaborator

It seems that this is quite huge change from the effectiveness's perspective. We should detect and fix this early. 🍻

@codecov-io
Copy link

codecov-io commented Jun 19, 2018

Codecov Report

Merging #1548 into master will decrease coverage by 1.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
- Coverage   41.29%   39.42%   -1.88%     
==========================================
  Files         257      255       -2     
  Lines       16988    17757     +769     
==========================================
- Hits         7016     7000      -16     
- Misses       9100     9883     +783     
- Partials      872      874       +2
Impacted Files Coverage Δ
daemon/mgr/container.go 36.26% <0%> (-14.19%) ⬇️
daemon/mgr/container_state.go 75.64% <0%> (-7.46%) ⬇️
daemon/config/config.go 14.41% <0%> (-5.34%) ⬇️
ctrd/watch.go 75% <0%> (-3.13%) ⬇️
ctrd/image.go 76.57% <0%> (-2.86%) ⬇️
daemon/mgr/volume.go 76.76% <0%> (-2.4%) ⬇️
daemon/mgr/container_types.go 73.91% <0%> (-2.21%) ⬇️
ctrd/container.go 49.45% <0%> (-0.73%) ⬇️
daemon/mgr/network.go 68.94% <0%> (-0.49%) ⬇️
cri/v1alpha1/cri.go 0% <0%> (ø) ⬆️
... and 6 more

@Letty5411 Letty5411 changed the title [WIP] bugfix: refine tests with specifying CMD bugfix: refine tests with specifying CMD Jun 19, 2018
Signed-off-by: letty <letty.ll@alibaba-inc.com>
@allencloud
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants