Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add webhook to notify our friend PouchRobot when circleci fails #1557

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

ZouRui89
Copy link
Contributor

Signed-off-by: Zou Rui 21751189@zju.edu.cn

Ⅰ. Describe what this PR did

This pr add webhook notification mechanism in circleci config file. In this case, when circleci fails our friend PouchRobot will make a comment to report.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@@ -53,6 +53,9 @@ jobs:
- run:
name: upload code coverage report
command: bash <(curl -s https://codecov.io/bash)
notify:
webhooks:
- url: http://121.201.63.16:6789/circleci_notifications
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 6788 to classified from the original one.

@codecov-io
Copy link

codecov-io commented Jun 20, 2018

Codecov Report

Merging #1557 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
- Coverage    41.3%   41.27%   -0.04%     
==========================================
  Files         267      267              
  Lines       17331    17331              
==========================================
- Hits         7159     7153       -6     
- Misses       9282     9287       +5     
- Partials      890      891       +1
Impacted Files Coverage Δ
ctrd/image.go 74.85% <0%> (-4.58%) ⬇️
apis/server/utils.go 64.28% <0%> (+4.76%) ⬆️

@ZouRui89 ZouRui89 changed the title feature: add notification from our friend PouchRobot when circleci fails feature: add webhook to notify our friend PouchRobot when circleci fails Jun 20, 2018
@allencloud
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants