enhance: display disconnect result for pouch network disconnect #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaloulcy
force-pushed
the
cli_show_disconnect_result
branch
from
0bc1260
to
6695f39
Compare
Codecov Report
@@ Coverage Diff @@
## master #1590 +/- ##
==========================================
- Coverage 41.84% 38.33% -3.52%
==========================================
Files 272 272
Lines 17681 19291 +1610
==========================================
- Hits 7399 7395 -4
- Misses 9370 10985 +1615
+ Partials 912 911 -1
|
rudyfly
reviewed
Jun 25, 2018
| } | ||
| fmt.Printf("container %s is disconnected from network %s\n", container, network) | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // networkDisconnectExample shows examples in 'disconnect' command, and is used in auto-generated cli docs. |
There was a problem hiding this comment.
need change the example command.
There was a problem hiding this comment.
fine. I have updated it. PTAL, thanks
|
Can you add more information about this pr? Such as change format from "A" to "B"... |
shaloulcy
force-pushed
the
cli_show_disconnect_result
branch
from
6695f39
to
f03b0d3
Compare
HusterWan
reviewed
Jun 27, 2018
cli/network.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| fmt.Printf("container %s is disconnected from network %s\n", container, network) |
There was a problem hiding this comment.
how about successfully disconnected ? :)
Signed-off-by: Eric Li <lcy041536@gmail.com>
shaloulcy
force-pushed
the
cli_show_disconnect_result
branch
from
f03b0d3
to
ea1afb4
Compare
|
lgtm |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Li lcy041536@gmail.com
Ⅰ. Describe what this PR did
enhance: display disconnect result for pouch network disconnect
Now If we disconnect a container from a network, it will display nothing. This PR will print the success message like
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
NONE
Ⅳ. Describe how to verify it
if pouch network disconnect successfully, it will print success
Ⅴ. Special notes for reviews