test: add unit test for generateMountBindings and modifySandboxNamespaceOptions #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1768 +/- ##
==========================================
+ Coverage 54.4% 63.83% +9.42%
==========================================
Files 200 200
Lines 15527 15527
==========================================
+ Hits 8448 9912 +1464
+ Misses 5962 4388 -1574
- Partials 1117 1227 +110
|
|
Ping @YaoZengzeng @starnop PTAL. Thanks a lot. |
ZouRui89
force-pushed
the
cri_test
branch
3 times, most recently
from
62b0d7f
to
480552b
Compare
ZouRui89
force-pushed
the
cri_test
branch
2 times, most recently
from
6ae239a
to
28a1499
Compare
…aceOptions Signed-off-by: Zou Rui <21751189@zju.edu.cn>
starnop
reviewed
Aug 3, 2018
| nsOpts: &runtime.NamespaceOption{ | ||
| HostIpc: true, | ||
| HostPid: true, | ||
| HostNetwork: false, |
There was a problem hiding this comment.
More test cases such as HostNetwork: true for higher test coverage ?
There was a problem hiding this comment.
What is the opinion of this comment from Starop? @ZouRui89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zou Rui 21751189@zju.edu.cn
Ⅰ. Describe what this PR did
This pr add unit test for method
generateMountBindingsandmodifySandboxNamespaceOptions.Ⅱ. Does this pull request fix one issue?
fixes part of #1756
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews