Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: complete the funtion of runtime status #1898

Merged

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Jul 26, 2018

Signed-off-by: Starnop starnop@163.com

Ⅰ. Describe what this PR did

complete the funtion of runtime status in cri.go

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Starnop <starnop@163.com>
@codecov-io
Copy link

Codecov Report

Merging #1898 into master will decrease coverage by 0.06%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
- Coverage   62.63%   62.56%   -0.07%     
==========================================
  Files         200      200              
  Lines       15565    15585      +20     
==========================================
+ Hits         9749     9751       +2     
- Misses       4573     4586      +13     
- Partials     1243     1248       +5
Flag Coverage Δ
#criv1alpha1test 33.25% <8.33%> (+0.02%) ⬆️
#criv1alpha2test 33.67% <8.33%> (-0.08%) ⬇️
#integrationtest 37.88% <0%> (-0.03%) ⬇️
#unittest 20.45% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 64.99% <16.66%> (-1.15%) ⬇️
cri/v1alpha1/cri.go 64.07% <16.66%> (-0.98%) ⬇️
cri/stream/portforward/httpstream.go 69.16% <0%> (-6.67%) ⬇️
cri/stream/runtime.go 71.01% <0%> (-2.9%) ⬇️
daemon/mgr/system.go 76.72% <0%> (+1.72%) ⬆️
ctrd/image.go 81.18% <0%> (+2.47%) ⬆️
cri/v1alpha2/cri_network.go 55.55% <0%> (+3.17%) ⬆️
cri/v1alpha1/cri_network.go 55.55% <0%> (+3.17%) ⬆️

@allencloud
Copy link
Collaborator

LGTM

@allencloud allencloud merged commit 33d90d2 into AliyunContainerService:master Aug 10, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants