test: run with volume whose destination is not empty #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
allencloud
reviewed
Jul 26, 2018
| // the container with default workdir successfully. | ||
| res := command.PouchRun("run", "--name", containerName, image, "ls") | ||
| defer DelContainerForceMultyTime(c, containerName) | ||
| res.Assert(c, icmd.Success) |
There was a problem hiding this comment.
Do we need to judge what content exits in the ls command's output?
There was a problem hiding this comment.
No
If the content of /opt/cni in the image have not be copied
---> the workdir /opt/cni/bin will not exist
---> we could not be able to run the container successfully.
Codecov Report
@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
+ Coverage 62.63% 62.65% +0.01%
==========================================
Files 200 200
Lines 15565 15565
==========================================
+ Hits 9749 9752 +3
+ Misses 4573 4566 -7
- Partials 1243 1247 +4
|
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng yaozengzeng@zju.edu.cn
Ⅰ. Describe what this PR did
test case for PR #1745
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews