Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add --name following container name in cmd #1924

Merged
merged 1 commit into from
Jul 30, 2018
Merged

bugfix: add --name following container name in cmd #1924

merged 1 commit into from
Jul 30, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Jul 30, 2018

make CI happy

Signed-off-by: Wei Fu fhfuwei@163.com

Ⅰ. Describe what this PR did

NONE

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

NONE

Ⅳ. Describe how to verify it

NONE

Ⅴ. Special notes for reviews

make CI happy

Signed-off-by: Wei Fu <fhfuwei@163.com>
@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Jul 30, 2018
@fuweid fuweid requested a review from Ace-Tang July 30, 2018 07:40
@codecov-io
Copy link

Codecov Report

Merging #1924 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
- Coverage    62.8%   62.78%   -0.02%     
==========================================
  Files         200      200              
  Lines       15567    15567              
==========================================
- Hits         9777     9774       -3     
- Misses       4544     4546       +2     
- Partials     1246     1247       +1
Flag Coverage Δ
#criv1alpha1test 33.25% <ø> (-0.03%) ⬇️
#criv1alpha2test 33.71% <ø> (-0.02%) ⬇️
#integrationtest 37.99% <ø> (+0.05%) ⬆️
#unittest 20.7% <ø> (ø) ⬆️
Impacted Files Coverage Δ
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/mgr/container.go 53.85% <0%> (-0.16%) ⬇️
cri/v1alpha2/cri.go 66.13% <0%> (+0.17%) ⬆️

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 30, 2018
@allencloud allencloud merged commit 9b8aa47 into AliyunContainerService:master Jul 30, 2018
@fuweid fuweid deleted the bugfix_add_name_in_create_in_case branch August 3, 2018 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants