Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit-test for apis/opts/portbindings.go #1951

Merged

Conversation

yuannauy123
Copy link
Contributor

Ⅰ. Describe what this PR did

add test cases for portbindings #1905

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@yuannauy123 Thanks for your contribution. 🍻
Please sign off in each of your commits.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @yuannauy123
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #1951 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1951      +/-   ##
=========================================
+ Coverage   63.31%   63.4%   +0.09%     
=========================================
  Files         200     200              
  Lines       15522   15522              
=========================================
+ Hits         9828    9842      +14     
+ Misses       4455    4437      -18     
- Partials     1239    1243       +4
Flag Coverage Δ
#criv1alpha1test 33.81% <ø> (-0.05%) ⬇️
#criv1alpha2test 34.31% <ø> (+0.03%) ⬆️
#integrationtest 38.39% <ø> (-0.04%) ⬇️
#unittest 20.99% <ø> (+0.13%) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 66.31% <0%> (-0.18%) ⬇️
daemon/mgr/container.go 53.85% <0%> (-0.16%) ⬇️
apis/opts/portbindings.go 80.95% <0%> (+80.95%) ⬆️

@allencloud allencloud changed the title add unit-test for apis/opts/portbindings.go areas/test test: add unit-test for apis/opts/portbindings.go Jul 31, 2018
@allencloud
Copy link
Collaborator

LGTM

@allencloud allencloud merged commit 7a555f1 into AliyunContainerService:master Aug 10, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants