bugfix: remove blobs and snapshot when remove image #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't add lease to the image since the containerdclient.Pull will add the lease. Signed-off-by: Wei Fu <fhfuwei@163.com>
HusterWan
reviewed
Aug 11, 2018
| @@ -196,8 +195,6 @@ func (c *Client) PullImage(ctx context.Context, ref string, authConfig *types.Au | |||
| } | |||
|
|
|||
| func (c *Client) pullImage(ctx context.Context, wrapperCli *WrapperClient, ref string, options []containerd.RemoteOpt) (containerd.Image, error) { | |||
| ctx = leases.WithLease(ctx, wrapperCli.lease.ID()) | |||
|
|
|||
| img, err := wrapperCli.client.Pull(ctx, ref, options...) | |||
There was a problem hiding this comment.
checked it. The GC doesn't clean your image if you don't remove it.
Codecov Report
@@ Coverage Diff @@
## master #2075 +/- ##
===========================================
+ Coverage 51.3% 63.85% +12.55%
===========================================
Files 209 209
Lines 16226 16225 -1
===========================================
+ Hits 8324 10361 +2037
+ Misses 6798 4570 -2228
- Partials 1104 1294 +190
|
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu fhfuwei@163.com
Ⅰ. Describe what this PR did
Don't add lease to the image since the containerdclient.Pull will add
the lease.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
the lease should be released after pull. The containerd client has this functionality so that we should add the one.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews