-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add cgroupfs in Info API #2148
feature: add cgroupfs in Info API #2148
Conversation
daemon/config/config.go
Outdated
// current pouchd only supports directly managing cgroupfs. | ||
// TODO: add 'systemd' to make systemd manage cgroupfs rather than directly using it. | ||
// In the future we will support this config in the daemon configuration. | ||
return "cgroupfs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we only support cgroupfs, systemd may put into consider, can you try to get this type from somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you try to get this type from somewhere
Could you explain a little bit more about the above sentence? @Ace-Tang Thanks a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not hardcode cgroup driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see. Thanks a lot.
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
==========================================
- Coverage 64.31% 62.56% -1.76%
==========================================
Files 209 209
Lines 16664 17579 +915
==========================================
+ Hits 10718 10998 +280
- Misses 4614 5208 +594
- Partials 1332 1373 +41
|
/LGTM |
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
2859bff
to
44d2080
Compare
Ping @Ace-Tang |
lgtm |
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
add cgroupfs in Info API.
current pouchd only supports directly managing cgroupfs. In the future we will support this config in the daemon configuration.
TODO: add 'systemd' to make systemd manage cgroupfs rather than directly using it.
Ⅱ. Does this pull request fix one issue?
fix #2143
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
added in integraion test.
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none