feature: support IntelRdtL3Cbm in pouch container #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
add-new-isolation-params
branch
2 times, most recently
from
ff90c77
to
fc3f480
Compare
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
allencloud
force-pushed
the
add-new-isolation-params
branch
from
fc3f480
to
9a43339
Compare
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
==========================================
- Coverage 13.61% 13.58% -0.04%
==========================================
Files 97 97
Lines 5912 5927 +15
==========================================
Hits 805 805
- Misses 5053 5068 +15
Partials 54 54
Continue to review full report at Codecov.
|
|
LGTM |
1 similar comment
|
LGTM |
pouchrobot
added
the
LGTM
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
In pouch, we need to support more container isolation options, such as Intel Rdt L3 Cbm. This PR added
IntelRdtL3Cbmfor pouchd.Ⅱ. Does this pull request fix one issue?
This is related to #688
This fixes #269
Ⅲ. Describe how you did it
None
Ⅳ. Describe how to verify it
None
Ⅴ. Special notes for reviews
In the following days, I will refactor the spec file in folder mgr. I think the structure of all spec files are a little bit casual, and we need to make it more structured.
This should be tested in AliOS 4.9, and could we make the test configure whether to run according to the type of CI system? Like travis CI, do not run this IntelRdtL3Cbm related test case, and run that in AliOS 4.9 CI system. @Letty5411