Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: finish top interface #900

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan zirenwan@gmail.com

Ⅰ. Describe what this PR did

finish top command

root@osboxes:test (zr/finish-top *) -> pouch top 44f675
UID     PID      PPID     C    STIME    TTY    TIME        CMD
root    28725    28714    0    3月14     ?      00:00:00    sh

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Michael Wan <zirenwan@gmail.com>
@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #900 into master will increase coverage by 0.22%.
The diff coverage is 35.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   14.21%   14.43%   +0.22%     
==========================================
  Files         118      118              
  Lines        7184     7253      +69     
==========================================
+ Hits         1021     1047      +26     
- Misses       6076     6117      +41     
- Partials       87       89       +2
Impacted Files Coverage Δ
daemon/mgr/container.go 2.68% <0%> (-0.09%) ⬇️
cli/top.go 0% <0%> (ø) ⬆️
ctrd/container.go 0% <0%> (ø) ⬆️
daemon/mgr/container_utils.go 60.82% <86.66%> (+11.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9943ac1...9294ba1. Read the comment docs.

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 15, 2018
@allencloud allencloud merged commit 0dc6fa0 into AliyunContainerService:master Mar 15, 2018
@HusterWan HusterWan deleted the zr/finish-top branch March 16, 2018 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants