Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: pouch info print information enhance #941

Merged

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan zirenwan@gmail.com

Ⅰ. Describe what this PR did

1. pretty print pouch info
2. add daemon listen address in info
3. add container count ing info

Ⅱ. Does this pull request fix one issue?

fixes: #920
fix part of #894

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

root@osboxes:pouch (zr/info-completion *) -> pouch info
Containers: 1
Running: 1
Paused: 0
Stopped: 0
Images:  0
Server Version: 0.3-dev
Storage Driver:
Driver Status: []
Logging Driver:
Cgroup Driver:
runc: <nil>
containerd: <nil>
Security Options: []
Kernel Version: 3.10.0-693.17.1.el7.x86_64
Operating System:
OSType: linux
Architecture:
HTTP Proxy:
HTTPS Proxy:
Registry: https://index.docker.io/v1/
Experimental: false
Debug: true
Labels: []
CPUs: 0
Total Memory: 0
Name:
ID:
Pouch Root Dir: /var/lib/pouch
LiveRestoreEnabled: false
Daemon Listen Addresses: [unix:///var/run/pouchd.sock]

Ⅴ. Special notes for reviews

Signed-off-by: Michael Wan <zirenwan@gmail.com>
@HusterWan
Copy link
Contributor Author

HusterWan commented Mar 22, 2018

prettyPrint may not pretty in code style, maybe someone can give me some advice about that.

@codecov-io
Copy link

Codecov Report

Merging #941 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   13.38%   13.27%   -0.11%     
==========================================
  Files         122      122              
  Lines        8039     8105      +66     
==========================================
  Hits         1076     1076              
- Misses       6867     6933      +66     
  Partials       96       96
Impacted Files Coverage Δ
cli/info.go 0% <0%> (ø) ⬆️
daemon/mgr/system.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e499bc...8ef6ad4. Read the comment docs.

@allencloud
Copy link
Collaborator

I think we can use a format template or just manually set the output.
LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 22, 2018
@allencloud allencloud merged commit 3790c91 into AliyunContainerService:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature required] pouch info cmd return more result
4 participants