fix: include contribution types in commit message (#414)

all-contributors · Sep 23, 2022 · 0839201 · 0839201 · vercel · Sep 23, 2022
1 parent 89dbc86
commit 0839201
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/lib/add-contributor.js b/lib/add-contributor.js
@@ -53,10 +53,15 @@ async function addContributor({
     originalSha: config.getOriginalSha(),
   };
 
+  const contributionsTitlePartLimit = 3
+  const arr = contributions.slice(0, contributionsTitlePartLimit);
+  if (arr.length > contributionsTitlePartLimit) arr[arr.length - 1] = `${contributions.length - 2} more`
+  const contributionsTitlePartText = arr.slice(0, arr.length - 1).join(', ') + ", and " + arr.slice(-1);
+
   const convention = config.get().commitConvention;
   const prTitle = convertMessage({
     tag: "docs",
-    msg: `add ${who} as a contributor`,
+    msg: `add ${who} as a contributor for ${contributionsTitlePartText}`,
     convention
   });
 

diff --git a/test/integration/__snapshots__/issue_comment.test.js.snap b/test/integration/__snapshots__/issue_comment.test.js.snap
@@ -444,7 +444,7 @@ Object {
 This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
   "head": "all-contributors/add-jakebolam",
   "maintainer_can_modify": true,
-  "title": "add jakebolam as a contributor",
+  "title": "add jakebolam as a contributor for code, doc, and infra",
 }
 `;
 
@@ -513,7 +513,7 @@ Object {
 This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
   "head": "all-contributors/add-jakebolam",
   "maintainer_can_modify": true,
-  "title": "add jakebolam as a contributor",
+  "title": "add jakebolam as a contributor for code, doc, and infra",
 }
 `;
 
@@ -588,7 +588,7 @@ Object {
 This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
   "head": "all-contributors/add-jakebolam",
   "maintainer_can_modify": true,
-  "title": "docs: add jakebolam as a contributor",
+  "title": "docs: add jakebolam as a contributor for code, doc, and infra",
 }
 `;
 
@@ -664,7 +664,7 @@ Object {
 This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
   "head": "all-contributors/add-jakebolam",
   "maintainer_can_modify": true,
-  "title": "add jakebolam as a contributor",
+  "title": "add jakebolam as a contributor for code, doc, and infra",
 }
 `;
 
@@ -772,7 +772,7 @@ Object {
 This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
   "head": "all-contributors/add-jakebolam",
   "maintainer_can_modify": true,
-  "title": "add jakebolam as a contributor",
+  "title": "add jakebolam as a contributor for code, doc, and infra",
 }
 `;
 
@@ -869,7 +869,7 @@ Object {
 This was requested by jakebolam [in this comment](https://github.com/all-contributors/all-contributors-bot/pull/1#issuecomment-453012966)",
   "head": "all-contributors/add-jakebolam",
   "maintainer_can_modify": true,
-  "title": "add jakebolam as a contributor",
+  "title": "add jakebolam as a contributor for code, doc, and infra",
 }
 `;