Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include contribution types in commit message #414

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

tenshiAMD
Copy link
Member

What:

  • Commit message does not include contribution types anymore.

Why:

  • Include contribution types in the commit message

How:

  • Update code regarding commit message

Checklist:

  • Documentation
  • Ready to be merged
  • Added myself to contributors table.
    Bot Usage

@tenshiAMD tenshiAMD self-assigned this Sep 17, 2022
@vercel
Copy link

vercel bot commented Sep 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
app ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 9:35AM (UTC)

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d40ae07) compared to base (89dbc86).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d40ae07 differs from pull request most recent head 0427f1b. Consider uploading reports for the commit 0427f1b to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #414   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          379       383    +4     
  Branches        41        42    +1     
=========================================
+ Hits           379       383    +4     
Impacted Files Coverage Δ
lib/add-contributor.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea.
I wonder if we should set a limit until which the contribution types are only specified (or all but the first one mentioned) in the description of the commit message (especially given certain pipelines on projects may lint commit messages on their length and fail on overly long commit messages).

@tenshiAMD
Copy link
Member Author

tenshiAMD commented Sep 22, 2022

It's a good idea. I wonder if we should set a limit until which the contribution types are only specified (or all but the first one mentioned) in the description of the commit message (especially given certain pipelines on projects may lint commit messages on their length and fail on overly long commit messages).

@Berkmann18 yes I agree with that. I suggest a max of 3 contribution types will be displayed per commit message and the exceeding will be on the commit description. Do you agree with that too?

@Berkmann18
Copy link
Member

It's a good idea. I wonder if we should set a limit until which the contribution types are only specified (or all but the first one mentioned) in the description of the commit message (especially given certain pipelines on projects may lint commit messages on their length and fail on overly long commit messages).

@Berkmann18 yes I agree with that. I suggest a max of 3 contribution types will be displayed per commit message and the exceeding will be on the commit description. Do you agree with that too?

That sounds good to me.

@tenshiAMD tenshiAMD changed the title fix: include contribution types in commit message WIP fix: include contribution types in commit message Sep 22, 2022
@tenshiAMD tenshiAMD force-pushed the fix/include-contribution-types-in-commit-message branch from aa8e670 to 0427f1b Compare September 23, 2022 09:35
@tenshiAMD tenshiAMD changed the title WIP fix: include contribution types in commit message fix: include contribution types in commit message Sep 23, 2022
@tenshiAMD
Copy link
Member Author

That sounds good to me.

@Berkmann18 done.

If 2 types

  • code and infra

If 3 types

  • code, design and infra

If 4 types or more

  • code, design, and 1 more
  • code, design, and 2 more
  • code, design, and 2 more

@tenshiAMD tenshiAMD merged commit 0839201 into master Sep 23, 2022
@tenshiAMD tenshiAMD deleted the fix/include-contribution-types-in-commit-message branch September 23, 2022 09:47
@github-actions
Copy link

🎉 This PR is included in version 1.16.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants