-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include contribution types in commit message #414
fix: include contribution types in commit message #414
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 379 383 +4
Branches 41 42 +1
=========================================
+ Hits 379 383 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea.
I wonder if we should set a limit until which the contribution types are only specified (or all but the first one mentioned) in the description of the commit message (especially given certain pipelines on projects may lint commit messages on their length and fail on overly long commit messages).
@Berkmann18 yes I agree with that. I suggest a max of 3 contribution types will be displayed per commit message and the exceeding will be on the commit description. Do you agree with that too? |
That sounds good to me. |
aa8e670
to
0427f1b
Compare
@Berkmann18 done. If 2 types
If 3 types
If 4 types or more
|
🎉 This PR is included in version 1.16.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What:
Why:
How:
Checklist:
Bot Usage