Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only comment about no contributions after checking all contributors #489

Merged

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Feb 17, 2024

What: Fixes #468.

Why: Currently, the bot comments "I couldn't determine ..." as soon as a potential contributor is found to not have any contributions. But if there are multiple potential contributors, that comment shouldn't happen.

How: With these changes, the comment is only added after all potential contributors are checked for sending a PR.

Checklist:

  • Documentation (n/a for bug fix)
  • Ready to be merged
  • [ ] Added myself to contributors table.

Copy link

vercel bot commented Feb 17, 2024

@JoshuaKGoldberg is attempting to deploy a commit to the All Contributors Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 5:15am

@@ -79,7 +79,7 @@
"created_at": "2019-01-10T08:36:52Z",
"updated_at": "2019-01-10T08:36:52Z",
"author_association": "MEMBER",
"body": "@all-contributors please add jakebolam for code, doc and infra"
"body": "@all-contributors please add jakebolam for code, doc and infra\n🤖 Beep boop! This comment was added automatically by [all-contributors-auto-action](https://github.com/marketplace/actions/all-contributors-auto-action).\nNot all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.\n...and of course, thank you for contributing! 💙"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get this change, that does not look like a comment that a user would post?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a comment a bot of mine posts that hits the issue. 🙂

Example: JoshuaKGoldberg/create-typescript-app#429 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh never seen this action! Cool!

@gr2m gr2m merged commit db6de74 into all-contributors:master Sep 12, 2024
1 of 2 checks passed
Copy link

🎉 This PR is included in version 1.19.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg deleted the no-contributions-delay-log branch September 12, 2024 21:17
@JoshuaKGoldberg
Copy link
Contributor Author

Hooray! Thanks @gr2m!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot both creates a PR and complains about no contributions when extra text in comment
2 participants