Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration for model locations #469

Open
buddha314 opened this issue Feb 28, 2023 · 3 comments
Open

Configuration for model locations #469

buddha314 opened this issue Feb 28, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@buddha314
Copy link

Allows for abstract model locations away from AWS. This file sets AWS as model source

https://github.com/allenai/scispacy/blob/main/scispacy/candidate_generation.py

For instance https://github.com/allenai/scispacy/blob/main/scispacy/candidate_generation.py#L43

Allow these to be set by environment or configuration files.
@dakinggg
Copy link
Collaborator

dakinggg commented Mar 5, 2023

Makes perfect sense @buddha314, I'd be happy to accept a PR doing this!

@dakinggg dakinggg added the enhancement New feature or request label Mar 5, 2023
@buddha314
Copy link
Author

Initial thinking is to take the root url as an environment variable with the AWS location as the default.

@dakinggg
Copy link
Collaborator

Makes sense, I might consider making a new LocalLinkerPaths that reads from environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@buddha314 @dakinggg