Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add block_time_f64 to Anvil #285

Closed
DaniPopes opened this issue Mar 12, 2024 · 1 comment · Fixed by #336
Closed

[Feature] Add block_time_f64 to Anvil #285

DaniPopes opened this issue Mar 12, 2024 · 1 comment · Fixed by #336
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DaniPopes
Copy link
Member

Component

nodes

Describe the feature you would like

foundry-rs/foundry#7380

This must be a separate method to not break the API, and also older versions will not support it

Additional context

No response
@DaniPopes DaniPopes added enhancement New feature or request good first issue Good for newcomers labels Mar 12, 2024
@lakshya-sky lakshya-sky mentioned this issue Mar 18, 2024
Merged
3 tasks
@lakshya-sky
Copy link
Contributor

Hello @DaniPopes, this is my first time opening a PR for alloy, I did my best to come up with a solution without changing too much code. If you think that we should have separate fields please let me know I would appreciate the nudge in correct direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add block_time_f64 to Anvil lakshya-sky/alloy
2 participants
@lakshya-sky @DaniPopes