Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bad checksum transactions are blocked #29

Closed
almindor opened this issue Jul 4, 2017 · 1 comment
Closed

Ensure bad checksum transactions are blocked #29

almindor opened this issue Jul 4, 2017 · 1 comment
Assignees
Milestone

Comments

@almindor
Copy link
Owner

almindor commented Jul 4, 2017

Add a opt-out setting that needs to be enabled (with a warning check pass) to allow bad checksum sends to work.

Now that EIP55 is finalized and supported by Etherwall and most others there should be no reason to allow bad checksum-ed addresses to be used. Example in #27

If users still need to do so they'll need to go to settings and specifically allow this operation in general before proceeding.

Transaction dialog should show this as an error otherwise and block the user from sending their ETH out.

@almindor almindor added this to the 2.1.0 milestone Jul 4, 2017
@almindor almindor self-assigned this Jul 4, 2017
@almindor almindor mentioned this issue Jul 4, 2017
@almindor
Copy link
Owner Author

Decided to not allow bad checksums at all and skip the complication of setting.

People can use etherscan to "double check" their destinations and get the properly CRCed addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant