Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable translated dates #2334

Open
callumknights opened this issue Jan 12, 2022 · 0 comments
Open

Re-enable translated dates #2334

callumknights opened this issue Jan 12, 2022 · 0 comments

Comments

@callumknights
Copy link
Contributor

callumknights commented Jan 12, 2022

There is currently a problem with the way dates are displayed in foreign languages.

RTL text and formatting seems to have been partly addressed with the usage of the metadata component. Although we're now back to having mixed translations in sentences, and English sentences that read RTL which isn't great. See here: https://www.gov.uk/government/publications/face-coverings-when-to-wear-one-and-how-to-make-your-own.ar

Dates and metadata tags had previously stopped being translated on purpose. See here: 2017156

Since these keys had since been translated, platform health attempted to re-enable these translations, only to bump into more issues with the way RTL translations are rendered. Max has detailed some of the issues in this now closed PR #2327

The image below shoes some of the issues platform health came across.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant