Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character count remaining characters message not visible #1406

Closed
NickColley opened this issue May 31, 2019 · 1 comment
Closed

Character count remaining characters message not visible #1406

NickColley opened this issue May 31, 2019 · 1 comment
Assignees
Labels
accessibility audit may 2019 Issues from May 2019 external accessibility audit, before version 3.0.0 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve.

Comments

@NickColley
Copy link
Contributor

This issue is from a May 2019 external accessibility audit report.

WCAG Reference: Usability feedback only, there is no WCAG related guidelines.
Issue ID: DAC_22
URL: http://govuk-frontend-v3.herokuapp.com/full-page-examples/feedback

Screen Shot

There is a character count that has been added to the text areas, however, the first ‘What are you trying to do?’ form field’s character count is not functioning and is not visible on the page. This is due to it being hidden using the CSS property of visibility:hidden; Although this may have been intentionally hidden, ZoomText users that rely on audio feedback were able to hear this information which was confusing as it was not visible to them on the page.

Current Code Ref(s)

<div class="govuk-form-group"> <label class="govuk-label" for="what-were-you-trying-to-do"> What were you trying to do? </label> <textarea class="govuk-textarea js-character-count" id="what-were-you-trying-to-do" name="what-were-you-trying-to-do" rows="5"></textarea> <span id="what-were-you-trying-to-do-info" class="govuk-hint govuk-character-count__message govuk-character-count__message--disabled" aria-live="polite">You have 100 characters remaining</span> </div>
.govuk-character-count__message--disabled { visibility: hidden; }

ZoomText user comments

“Asked to enter more characters than required, I noted that there was no visible instruction next to the form to make the user aware of this limit. Also, by randomly swiping across the bottom of the form, I noted an audible label informing me of a character limitation, but this was not visible. Having entered excessive characters, a visible message did inform a user of this.”

Solution

Ensure that, if the count is to be hidden, that it is hidden from all users, which may require the use of display:none and aria-hidden.

@NickColley NickColley added accessibility awaiting triage Needs triaging by team audit may 2019 Issues from May 2019 external accessibility audit, before version 3.0.0 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve. Priority: low and removed awaiting triage Needs triaging by team labels May 31, 2019
@NickColley NickColley self-assigned this Jun 10, 2019
@kellylee-gds
Copy link
Contributor

Closed in #1442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility audit may 2019 Issues from May 2019 external accessibility audit, before version 3.0.0 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
Development

No branches or pull requests

2 participants