Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write and share a proposal for internationalisation #1715

Closed
9 tasks done
Tracked by #1708
NickColley opened this issue Jan 24, 2020 · 7 comments
Closed
9 tasks done
Tracked by #1708

Write and share a proposal for internationalisation #1715

NickColley opened this issue Jan 24, 2020 · 7 comments

Comments

@NickColley
Copy link
Contributor

NickColley commented Jan 24, 2020

What

Write and share a proposal for our approach to internationalisation, specifically translating hardcoded strings in component JavaScript. The proposal needs to include:

  • details of how we expect people to pass translations into component JS
  • any specific questions or concerns we have that we'd like to get feedback on
  • who we'd like to hear from, e.g: if we think questions may be answered by a specific audience
  • a way to get in touch or show an interest in being approached by our team with any follow-up questions

We're going to post this proposal as a Github discussion, and share it via Slack and the mailing list.

Why

Internationalisation is complex and we want to make sure that our approach works for service teams. We've already identified some potential things that may cause issues for service teams, but we don't have confidence in knowing whether they are real problems or not.

Who needs to know about this

Developers; Tech Writer

Depends on

#1714

Done when

  • Draft a proposal
  • Decide how to share the proposal, e.g: Github discussions vs Github PR in architecture repo vs anything else
  • Decide how long we want to give for feedback
  • Share the proposal with the community on Slack
  • Share the proposal via the mailing list
  • Decide on what to do next based on community feedback
  • Reply to comment from port maintainer asking for a JSON file of translations and ask for clarity on why and what they'd use it for
  • Provide an update explaining the data-attributes approach we'll be implementing too.
  • Close proposal
@vanitabarrett vanitabarrett changed the title Write and share proposal component options with the community for feedback Write and share a proposal for internationalisation Mar 1, 2022
@querkmachine
Copy link
Member

I've drafted a proposal, however we're unsure as to how necessary this is as we have two draft PRs already created. We may wish to produce comms and have people review the PRs directly, rather than solicit feedback on a proposal document.

@NickColley
Copy link
Contributor Author

NickColley commented Jun 1, 2022

Just so you know that proposal is hidden from outside GDS, so you might want to consider making it public only or copying it into your message if it contains anything useful for the record going forwards.

I don't think there's anything wrong with doing most of the work in practical code but the main thing is to get feedback like you say.

@trang-erskine
Copy link

No longer relevant.

@vanitabarrett vanitabarrett reopened this Jul 28, 2022
@vanitabarrett vanitabarrett self-assigned this Jul 29, 2022
@vanitabarrett
Copy link
Contributor

@querkmachine I've suggested some changes to your original proposal. Would you be happy to go review and accept/reject/comment as you see fit?

@vanitabarrett
Copy link
Contributor

Proposal has been published as a new Github discussion here: #2740

@calvin-lau-sig7 is currently reviewing the comms I've put together, and I'll send them out once we're happy with them.

I've set a deadline for feedback of 12th August for now, as we mentioned giving people at least 1 week.

@vanitabarrett
Copy link
Contributor

Moving this into Blocked until 12th August

@vanitabarrett
Copy link
Contributor

Feedback gathered and actions noted down in this doc: https://docs.google.com/document/d/1B9ag7WPN0dDuBxVSKntVBxUM7Y7xVTKromKPcZwIjZc/edit#

@vanitabarrett vanitabarrett removed their assignment Aug 15, 2022
@domoscargin domoscargin self-assigned this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants