Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing govukHint to wrap its content in a DIV rather than a SPAN #1835

Closed
matthewmascord opened this issue Jun 11, 2020 · 1 comment · Fixed by #1855
Closed

Consider changing govukHint to wrap its content in a DIV rather than a SPAN #1835

matthewmascord opened this issue Jun 11, 2020 · 1 comment · Fixed by #1855
Assignees
@vanitabarrett
Labels
hint 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Milestone
v3.8.0

Comments

@matthewmascord
Copy link
Contributor

matthewmascord commented Jun 11, 2020 •
edited
Loading

Services may have a valid reason to include hint copy that includes block level elements such as P or UL. For example, on the Gov.UK cookies page, https://www.gov.uk/help/cookies

At the moment the govukHint component wraps the markup it accepts in a SPAN and this causes HTML validation errors if developers include block level elements because block level elements are not allowed within a SPAN.

https://github.com/alphagov/govuk-frontend/tree/master/src/govuk/components/hint
@hannalaakso hannalaakso added the awaiting triage Needs triaging by team label Jun 11, 2020
@36degrees
Copy link
Contributor

This also came up in alphagov/govuk-design-system#778 (comment)

@timpaul timpaul added 🕔 hours A well understood issue which we expect to take less than a day to resolve. hint and removed awaiting triage Needs triaging by team labels Jun 16, 2020
@vanitabarrett vanitabarrett self-assigned this Jul 8, 2020
@vanitabarrett vanitabarrett mentioned this issue Jul 8, 2020
Merged
@36degrees 36degrees added this to the [NEXT] milestone Jul 8, 2020
@vanitabarrett vanitabarrett mentioned this issue Dec 15, 2021
Merged
@kr8n3r kr8n3r mentioned this issue Jan 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vanitabarrett vanitabarrett

Labels
hint 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v3.8.0
Development

Successfully merging a pull request may close this issue.

Hint component can render block-level elements as valid HTML alphagov/govuk-frontend
5 participants
@36degrees @timpaul @hannalaakso @matthewmascord @vanitabarrett