-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider alternative names for the I18n
class
#2926
Comments
How about |
As we're making the I18n class private (see #2927) I'm not too fussed about resolving this before we ship v4.4.0 as we can change the name without it being a breaking change. Obviously if we were planning on making it public at some point we'd want to revisit this first. With that in mind are we happy to take this out of the v4.4.0 milestone and push this conversation down the line a bit? |
I'm happy with the "private + same name" combo 👍 Consider it considered, or rename it to Consider making the As in, once we're happy it's stable and well documented |
Sounds good to leave it on the side for now and revisit when/if we make the API public at some point in the future. No need to hold up 4.4.0 for an internal name 😄 |
That said, the <div ... data-i18n.charactersUnderLimit="...." ...>...</div> new CharacterCount($element, {
i18n: {
charactersUnderLimit: ...
...
}
...
}) |
My vague bullet-point thoughts on potential names.
|
Have removed from the milestone and will close this in favour of adding a note to #2977 to re-consider the name before making it public. |
What
As a team we're not sure if our
I18n
"Internationalisation" class is fully-featured enough to carry the name. The class does most of what we need but (knowingly) lacks various features we may need in the future.Do we need a new name? We should investigate
Why
These features were noted as not supported during the original spike:
#2614 [DO NOT MERGE] Internationalisation support
We're also aware of things like:
Is that a problem?
Who needs to work on this
Developers, Content Designers
Who needs to review this
Developers, Content Designers
Done when
The text was updated successfully, but these errors were encountered: