Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw errors during Character Count initialisation if key HTML elements are missing #4125

Closed
1 task
Tracked by #3478
romaricpascal opened this issue Aug 24, 2023 · 1 comment · Fixed by #4261
Closed
1 task
Tracked by #3478

Throw errors during Character Count initialisation if key HTML elements are missing #4125

romaricpascal opened this issue Aug 24, 2023 · 1 comment · Fixed by #4261
Assignees
@romaricpascal
Labels
character count javascript
Milestone
v5.0

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Aug 24, 2023 •
edited
Loading

What

Update our JavaScript components requiring specific HTML elements to be present so they throw a MissingElementError (extending GOVUKFrontendError) rather than silently fail:

  • The input/textarea
  • The textarea description

Why

This is part of our work to have our components throw rather than silently return during initialisation.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Component has been updated to throw errors
@romaricpascal romaricpascal added this to the v5.0 milestone Aug 24, 2023
@romaricpascal romaricpascal moved this from Backlog 🗄 to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Aug 24, 2023
@romaricpascal romaricpascal mentioned this issue Aug 24, 2023
Closed
@romaricpascal romaricpascal mentioned this issue Aug 24, 2023
Closed
3 tasks
@domoscargin domoscargin moved this from Sprint Backlog 🏃🏼‍♀️ to Blocked ⛔ in GOV.UK Design System cycle board Aug 24, 2023
@domoscargin domoscargin moved this from Blocked ⛔ to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Sep 7, 2023
@romaricpascal
Copy link
Member Author

A little heads up on the wording, where we've tried to align the messages of the tests for the errors to throws when ... is missing [ + optional extra context]

@romaricpascal romaricpascal moved this from Sprint Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board Sep 25, 2023
@romaricpascal romaricpascal self-assigned this Sep 25, 2023
@romaricpascal romaricpascal mentioned this issue Sep 25, 2023
Merged
@36degrees 36degrees moved this from In progress 📝 to Ready to release 🚀 in GOV.UK Design System cycle board Sep 27, 2023
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romaricpascal romaricpascal

Labels
character count javascript
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Throw ElementError for missing elements during Character count instantiation alphagov/govuk-frontend
1 participant
@romaricpascal