Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio circles are sometimes misaligned/not centred #5104

Closed
tom-clarke-dluhc opened this issue Jun 26, 2024 · 5 comments
Closed

Radio circles are sometimes misaligned/not centred #5104

tom-clarke-dluhc opened this issue Jun 26, 2024 · 5 comments
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) radios

Comments

@tom-clarke-dluhc
Copy link

tom-clarke-dluhc commented Jun 26, 2024

Description of the issue

When using the radio component the concentric circles for a selected option are sometimes not centred for specific browser/zoom percentages.

an example screenshot from the govuk frontend showing circles that don't share a centre when zoom is set to 90%

Steps to reproduce the issue

On the frontend example, while using Edge browser and a zoom of 90% the middle circle is quite a way from the middle. This can also be seen for 80% and some other common zoom percentages.

Actual vs expected behaviour

I would expect the circles to always be centred but they aren't for some zooms.

Environment (where applicable)

  • Operating system: Windows 10
  • Browser: Edge
  • Browser version: 126
  • GOV.UK Frontend Version: most recent
@tom-clarke-dluhc tom-clarke-dluhc added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels Jun 26, 2024
Copy link

Uh oh! @tom-clarke-dluhc, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@tom-clarke-dluhc
Copy link
Author

@kateriley1

@querkmachine
Copy link
Member

This is caused by how browsers round fractional values to full pixels at certain zoom levels. There's a fuller explanation in the backlog issue here: alphagov/govuk-design-system-backlog#59 (comment)

@tom-clarke-dluhc
Copy link
Author

Thanks for the reply. Good to know that there's not much that can be done to resolve

@romaricpascal romaricpascal added radios and removed awaiting triage Needs triaging by team labels Sep 10, 2024
@romaricpascal
Copy link
Member

I'm going to close this one as there is no action we can take to solve this and we have some documentation in our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) radios
Projects
None yet
Development

No branches or pull requests

3 participants