-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review application can mislead if a component is polyfilled #674
Labels
Comments
Had a hard time trying to figure out why our classList polyfill wasn't working in IE8 tabs in the Design System. Compared it to FT's script dependencies and found that it also needed the Element polyfill, which isn't imported in the our classList javascript file. |
This was referenced Nov 14, 2018
4 tasks
Closing as once we've done #2506 we'll no longer be manually including polyfills in our JavaScript code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our review application uses the 'all' JavaScript bundle.
If a polyfill is defined in one component it can also solve issues in another component, without explicitly importing them.
We could consider only initialising components on their respective pages.
Work around: Uncomment other components when testing them.
This ties into #660
The text was updated successfully, but these errors were encountered: