Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate - New Frontend component imports aren't covered by the update process #1479

Closed
1 task done
joelanman opened this issue Jul 22, 2022 · 4 comments
Closed
1 task done
Milestone

Comments

@joelanman
Copy link
Contributor

joelanman commented Jul 22, 2022

What

The GOVUK Frontend components are all imported in app/views/layout.html. We should investigate if thats the right approach, and/or add to the update process.

Why

This is in user space, and is not currently covered by the update process. If a user updates an existing prototype and tries to use a new component, it won't work.

We can tell people to add the new line themselves in release notes, but thats not ideal.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We've investigated importing components and have an idea for a new approach
@lfdebrux
Copy link
Member

This feels like something that is part of the wider extensions story... I feel like extensions should be able to tell the kit to import macros into the base layout 🤔

@lfdebrux lfdebrux added this to the v13 milestone Oct 11, 2022
@lfdebrux
Copy link
Member

I think this is covered by the changes @nataliecarey has suggested for GOV.UK Frontend: alphagov/govuk-frontend#2851

@colinrotherham
Copy link
Contributor

@lfdebrux @nataliecarey Lots of moving parts of this one, nearly there: alphagov/govuk-frontend#2851 (comment)

Please jump on with any extra feedback

Just updating our build to write out the config

@joelanman
Copy link
Contributor Author

I think this one is done - we have a new approach, awaiting next Frontend release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants