Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in HTML output #137

Closed
ch-rfishwick opened this issue Nov 1, 2019 · 3 comments
Closed

Error in HTML output #137

ch-rfishwick opened this issue Nov 1, 2019 · 3 comments

Comments

@ch-rfishwick
Copy link

ch-rfishwick commented Nov 1, 2019

HTML pages rendered from markdown contain a number of errors, at least one of which is also present in the webpage generated using the template in the example project.

@NickColley
Copy link
Contributor

NickColley commented Nov 1, 2019

Hello @ch-rfishwick !

I have removed your zip download as it could be dangerous for us to download.
However I have reproduced the output with the online validator:

https://validator.w3.org/nu/?doc=https%3A%2F%2Ftdt-documentation.london.cloudapps.digital%2F%23technical-documentation-template

The errors that we intend to fix are recorded here:

The other warnings are not a cause for concern: alphagov/govuk-frontend#1280 (comment)

Since we're tracking these already I'm going to close your issue out thanks for raising this with us.

@ch-rfishwick
Copy link
Author

ch-rfishwick commented Nov 4, 2019

I believe we were comparing different pages. The error (not warning) to which I was referring can be found if you simply run the example project with the tech-docs-gem repo (or any generated projects) and has to do with the crown logo.

The error description is 'Attribute src not allowed on element image at this point.', found on line 69, columns 13 to 154.

The actual code snippet under suspicion:

<image src="/assets/images/govuk-logotype-crown.png" xlink:href="" class="govuk-header__logotype-crown-fallback-image" width="36" height="32">

@NickColley
Copy link
Contributor

Hello @ch-rfishwick,

If you look at this GitHub issue it covers warnings that are not a problem here: alphagov/govuk-frontend#1280

That specific issue is an intentional fallback for older browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants