Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape key to close popup and panel #65

Closed
balmas opened this issue Feb 5, 2018 · 1 comment
Closed

escape key to close popup and panel #65

balmas opened this issue Feb 5, 2018 · 1 comment

Comments

@balmas
Copy link
Member

balmas commented Feb 5, 2018

  • Click on a link or button in the popup should anchor it (i.e. require click on X to close)
  • Click outside the popup should close it
  • Escape should close the popup and the panel (in reverse order from which they were opened if both are open)
@balmas balmas closed this as completed in 2db97db Feb 15, 2018
@balmas balmas reopened this Feb 15, 2018
@balmas balmas changed the title additional means to close popup and panel escape key to close popup and panel Feb 15, 2018
@balmas
Copy link
Member Author

balmas commented Feb 15, 2018

2db97db adds support for escape key to close. Clicking outside the popup to close has been moved to #81

@balmas balmas closed this as completed Feb 15, 2018
@balmas balmas assigned monzug and unassigned monzug Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants