-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #70
Comments
|
|
|
|
|
|
|
|
|
|
|
|
Same comments apply to |
|
Applies to both |
|
|
|
|
|
|
would be good to know if the functions return anything, if at all.. thanks |
All API methods should return a gun reference context that you can chain off of. Or were you talking about other functions? |
thanks. will ask a follow up question on gitter if that's ok.. |
Yupe. :) |
Docs have now been rewritten like... 2 or 3 times since July 2015? Definitely all could be improved, but I'm gonna say it is safe to close this issue. If there are still problems: Please feel free to contribute and improve the docs (they are a wiki)! Or asking questions on Stackoverflow tagged "gun" is great. And help on gitter. gun.js.org website needs updated docs though. Will probably add some JS there that auto-pulls from github's wiki API so it is always recent. But that is a separate thing, so I'm gonna close this one, now finally! But PLEASE do complain/help/contribute to doc clarity. |
Looks like this was being used to cover ALL core documentation clarity. Woops! So I'm gonna keep it open for future use instead. |
there's no content for |
@KhaledElAnsari good observation! I'll add that to the TODO list of things to address in the documentation. It still exists, but end-user-developers don't really need to use it, but it should still be documented! If you have any specific question about it right now I can try to answer it. |
I'm still reading about Gun, hopefully I can use it in my next project. good job by the way |
In the docs, regarding the constructor it states:
That is not actually true. The object must NOT be empty, it must be in the format of {url: "your_url"} |
@plentylife yeah some meta-data got added to the peer objects since then, they look more like this:
Now note, you do not have to pass it like that it just upgrades internally into an object that is represented like that. If you see anything that is wrong in the docs, https://github.com/amark/gun/wiki/API is a wiki that can be edited, so feel free to improve it for everybody! |
@amark I couldn't get it to work, unless I passed it with a |
@amark The docs say we can use |
wouldnt it be better to have monothematic issues on documentation, marked with a label "documentation" ? |
@feat7 server1.com/gun was suppose to be an example URL, not a real/actual URL. Fair point though, when we launch AXE hopefully we can update this with real URLs that anybody can use. https://gun.eco/docs/Installation#node should have some more info on how to setup - do those docs (and related pages) help at all, or need changes? @thoka monothematic? I'm not sure what you mean, but sure! I think you have contributor access/rights? If not, I can give them to you, to help change whatever needs to be changed to make things better :) |
@amark monothematic: one issue <=> one topic |
Seems like constructor params at the gunjs-notes-app/server.js example Neither 'file' parameter nor 'web' one.. Seems confusing especially for the basic example. |
I've found many similar discrepancies - and asked @amark about them a couple of days ago before he went on vacation. If I understood correctly he suggested adding discrepancies to the Wiki and he'd edit/correct them later. The most common I've found are additional optional arguments (such as this case). |
I would also gladly accept contrib rights as well to help clarify and organize documentation structure. |
@bugs181 Docs are all openly editable via the Wiki here in Github. |
@Dletta There were a couple other things I thought I could help out with. Mostly cleaning up Git issues. I see a lot of users asking questions but their Markdown skills are limited. I could clean these issues up to be more readable as well. |
Not sure if it is a bug or documentation fault, but |
The semantics of map/on/once are not entirely clear. In particular it seems that a chain of |
My guess would be that it would mean that they haven't been programmed yet, but I really don't think that is true. If it is true, then that idea should be conveyed in a less ambiguous way. |
@davidbludlow good point! create/auth/recall should be stable, the others removed until future notice. Please help and delete them: https://github.com/amark/gun/wiki |
The example can be misleading to beginners: gun.opt({peers: ['http://server1.com/gun', 'http://server2.com/gun']}); // re-add peers to GUN-options
gun.get('heartbeat').put("heartbeat") // optional: tell GUN to put something small, forcing GUN to establish connection, as GUN is lazy by nature to make it save on data transfer. This throws :
If the database is empty, so here an object should be used, e.g.: |
The
|
{obj:'ect'}
?The text was updated successfully, but these errors were encountered: