Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all the reference of data model to abstract data type in generate subcommand #69

Closed
desaikd opened this issue Nov 27, 2023 · 1 comment
Closed

Rename all the reference of data model to abstract data type in generate subcommand #69

desaikd opened this issue Nov 27, 2023 · 1 comment
Labels
code generation Improvements for code generation subcommand `generate`

Comments

@desaikd
Copy link
Contributor

desaikd commented Nov 27, 2023

I think a better name for this would be AbstractDataType. A DataModel is a collection of data types (which this enum itself is), but in the places we use this enum we're always talking about one of its variants (i.e. a particular abstract data type).

The data types are "abstract" in that they are not particular to ISL or to the target language.

Originally posted by @zslayton in #61 (comment)
@desaikd desaikd added the code generation Improvements for code generation subcommand `generate` label Nov 27, 2023
@desaikd desaikd mentioned this issue Nov 27, 2023
Merged
@desaikd desaikd mentioned this issue Feb 7, 2024
Merged
@desaikd
Copy link
Contributor Author

desaikd commented Apr 18, 2024

Finished with #81

@desaikd desaikd closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code generation Improvements for code generation subcommand `generate`
Projects
Code generation using Ion Schema
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@desaikd