Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C extension supports 9 timestamp precision now. It might need to support more as needed. #160

Open
cheqianh opened this issue Jul 7, 2021 · 2 comments
Open

C extension supports 9 timestamp precision now. It might need to support more as needed. #160

cheqianh opened this issue Jul 7, 2021 · 2 comments
Labels
C extension Ion python C extension enhancement

Comments

@cheqianh
Copy link
Contributor

cheqianh commented Jul 7, 2021 •
edited
Loading

Right now C extension only supports at most 6 timestamp precision, it would be nice to support more.

E.g., 2016-02-02T00:00:30.12345678901234-00:00 will be read as 2016-02-02T00:00:30.123456-00:00
@cheqianh cheqianh added enhancement C extension Ion python C extension labels Jul 7, 2021
@cheqianh
Copy link
Contributor Author

cheqianh commented Aug 13, 2021 •
edited
Loading

It would be good to support at least 9 digits for some customers.

@cheqianh cheqianh mentioned this issue Aug 27, 2021
Merged
@cheqianh
Copy link
Contributor Author

cheqianh commented Sep 7, 2021 •
edited
Loading

Above commit changed C extension to support 9 sub-second digits now.

@cheqianh cheqianh changed the title C extension only supports 6 timestamp precision. C extension supports 9 timestamp precision now. It might need to support more as needed. Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C extension Ion python C extension enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cheqianh