Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give users a way to implement IonInput for their own types #783

Open
zslayton opened this issue Jun 4, 2024 · 0 comments
Open

Give users a way to implement IonInput for their own types #783

zslayton opened this issue Jun 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@zslayton
Copy link
Contributor

zslayton commented Jun 4, 2024

Due to coherence limitations, the IonInput trait cannot provide blanket impls for all of the Read types that it could. This can lead to frustrating situations in which a user would like to read Ion from a common type but cannot without first wrapping it in a BufReader or similar.

This could be addressed by making IonStream and IonSlice pub (potentially without exposing any of their methods).

@zslayton zslayton added the bug Something isn't working label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant