Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define an MSRV policy for the crate #800

Open
zslayton opened this issue Jul 23, 2024 · 3 comments
Open

Define an MSRV policy for the crate #800

zslayton opened this issue Jul 23, 2024 · 3 comments

Comments

@zslayton
Copy link
Contributor

          > while we still can

There's a cfg_version RFC that will help with this.

Also, if we haven't already done so, we should define a MSRV policy for this crate.

Originally posted by @popematt in #796 (comment)

@zslayton
Copy link
Contributor Author

I propose stealing the MSRV policy from the jiff crate, as it seems reasonable to me:

This crate's minimum supported rustc version is 1.70.0.

The policy is that the minimum Rust version required to use this crate can be increased in minor version updates. For example, if jiff 1.0 requires Rust 1.20.0, then jiff 1.0.z for all values of z will also require Rust 1.20.0 or newer. However, jiff 1.y for y > 0 may require a newer minimum version of Rust.

@popematt
Copy link
Contributor

@zslayton, would it be fair to summarize that as "increasing the MSRV requires a new minor version"?

Another one that looks reasonable to me is this proposal for libc.

@zslayton
Copy link
Contributor Author

would it be fair to summarize that as "increasing the MSRV requires a new minor version"?

Yes, without a "we support the last N releases" requirement. I could get behind a "last N" policy for a sufficiently small N.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants