Implements if_none and friends
#875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
+ Coverage 77.68% 77.74% +0.05%
==========================================
Files 136 136
Lines 34188 34392 +204
Branches 34188 34392 +204
==========================================
+ Hits 26558 26737 +179
- Misses 5648 5666 +18
- Partials 1982 1989 +7 ☔ View full report in Codecov by Sentry. |
jobarr-amzn
approved these changes
Dec 10, 2024
Comment on lines
+413
to
415
| template( | ||
| "(macro default (expr* default_expr*) (.if_none (%expr) (%default_expr) (%expr) ))", | ||
| ), |
There was a problem hiding this comment.
It's nice to see these things pay off.
Co-authored-by: Joshua Barr <70981087+jobarr-amzn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
if_noneif_someif_singleif_multidefault(in terms ofif_none)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.