Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript types or definitelytyped #1918

Closed
oliverlj opened this issue Nov 26, 2019 · 7 comments
Closed

Typescript types or definitelytyped #1918

oliverlj opened this issue Nov 26, 2019 · 7 comments
Labels

Comments

@oliverlj
Copy link

I use this library in an ember app with typescript. Is is possible to have the types definition .d.ts ? or make a package inside http://definitelytyped.org/ ?

@martynasma
Copy link
Collaborator

@oliverlj
Copy link
Author

I've completed this.
This will add the javascript libraby in node_modules.

Vscode tells me
Cannot find module '@amcharts/amcharts4/charts'.ts(2307) on
import * as am4charts from '@amcharts/amcharts4/charts';

because there is no types defided

@oliverlj
Copy link
Author

there is a type definition for amcharts v3 here https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/amcharts

@martynasma
Copy link
Collaborator

Did you install @amcharts/amcharts4 package in your app?

@oliverlj
Copy link
Author

Thanks, this made the job
npm install --save-dev @amcharts/amcharts4

Maybe the docs could be updated ?

@oliverlj
Copy link
Author

I think now i have the dependency size issue
#569

⠴ building... [Bundler][BABEL] Note: The code generator has deoptimised the styling of /home/oliver/git/fritzy/fritzy-front/node_modules/pdfmake/build/pdfmake.js as it exceeds the max of 500KB.
⠦ building... [Bundler][BABEL] Note: The code generator has deoptimised the styling of /home/oliver/git/fritzy/fritzy-front/node_modules/@amcharts/amcharts4/.internal/pdfmake/vfs_fonts.js as it exceeds the max of 500KB.
⠴ building... [Bundler][BABEL] Note: The code generator has deoptimised the styling of /home/oliver/git/fritzy/fritzy-front/node_modules/xlsx/xlsx.js as it exceeds the max of 500KB.

@oliverlj
Copy link
Author

oliverlj commented Dec 6, 2019

All is fine, just a babel info log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants