Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Html lang accessibility error #72

Open
mradeybee opened this issue Oct 29, 2019 · 3 comments
Open

Html lang accessibility error #72

mradeybee opened this issue Oct 29, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@mradeybee
Copy link

Screen Shot 2019-10-29 at 2 56 42 PM

There is no default language set in the html tag.
@amclin amclin added the enhancement New feature or request label Oct 29, 2019
@mradeybee mradeybee mentioned this issue Oct 31, 2019
Closed
@amclin
Copy link
Owner

amclin commented Nov 19, 2019

I'm thinking this would be ideal to expand into a generalized localization solution. This library may be a good solution: https://github.com/isaachinman/next-i18next

@KevinDanikowski
Copy link

this can now be closed, fixed #166

@amclin
Copy link
Owner

amclin commented Jan 15, 2020

It's hard-coded here:
https://github.com/amclin/react-project-boilerplate/pull/166/files?file-filters%5B%5D=.json&file-filters%5B%5D=.jsx&file-filters%5B%5D=.snap&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile&hide-deleted-files=true#diff-3a602c0718165d60493fa7f84f874105R19

So I'd still like to keep this open until it's moved to a configurable value

@amclin amclin mentioned this issue Jan 15, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amclin @mradeybee @KevinDanikowski