fix: dumpDiffToConsole base64 string output #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anescobar1991
requested changes
Mar 1, 2020
| @@ -213,7 +213,7 @@ function diffImageToSnapshot(options) { | |||
| diffOutputPath, | |||
| diffRatio, | |||
| diffPixelCount, | |||
There was a problem hiding this comment.
Can we add an integration test for this?
There was a problem hiding this comment.
An existing spec was actually doing this incorrectly (or rather incompletely), so I fixed it.
anescobar1991
approved these changes
Mar 2, 2020
|
|
JAdshead
approved these changes
Mar 17, 2020
|
I believe it's not yet released.
… On 2020-03-21, at 11:17, 骗你是小猫咪 ***@***.***> wrote:
Still have.
https://github.com/shaodahong/ant-design/runs/523791984?check_suite_focus=true
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@bstst Thanks for your reply, |
14 tasks
|
@anescobar1991 Is there a plan for a new release? thanks |
|
Yes, once #179 is merged we will then have everything publish on merge. |
oneamexbot
added a commit
that referenced
this pull request
Mar 24, 2020
# [3.0.0](v2.12.0...v3.0.0) (2020-03-24) ### Bug Fixes * **diff:** small default maxBuffer ([df713f6](df713f6)) * **diff-snapshot:** dumpDiffToConsole base64 string output ([#183](#183)) ([f73079f](f73079f)) ### chore * **packages:** updating jest to 25.1 for perf improvements ([#170](#170)) ([eb3dfa6](eb3dfa6)) * **packages:** upgrade from pixelmatch 4.x to 5.x, and pngjs to 3.4 ([#186](#186)) ([1edc9a3](1edc9a3)) * **travis:** remove node 6 from travis config ([ce2b757](ce2b757)) ### Features * **diff:** increase the maxBuffer to 10MB for the diff process ([#167](#167)) ([0927826](0927826)) ### BREAKING CHANGES * **packages:** pixelmatch is being major version bumped and so image diffs may be difference * **packages:** Node min version is now 8 * **travis:** drop support for node 6
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
# [3.0.0](americanexpress/jest-image-snapshot@v2.12.0...v3.0.0) (2020-03-24) ### Bug Fixes * **diff:** small default maxBuffer ([df713f6](americanexpress@df713f6)) * **diff-snapshot:** dumpDiffToConsole base64 string output ([americanexpress#183](americanexpress#183)) ([f73079f](americanexpress@f73079f)) ### chore * **packages:** updating jest to 25.1 for perf improvements ([americanexpress#170](americanexpress#170)) ([eb3dfa6](americanexpress@eb3dfa6)) * **packages:** upgrade from pixelmatch 4.x to 5.x, and pngjs to 3.4 ([americanexpress#186](americanexpress#186)) ([1edc9a3](americanexpress@1edc9a3)) * **travis:** remove node 6 from travis config ([ce2b757](americanexpress@ce2b757)) ### Features * **diff:** increase the maxBuffer to 10MB for the diff process ([americanexpress#167](americanexpress#167)) ([0927826](americanexpress@0927826)) ### BREAKING CHANGES * **packages:** pixelmatch is being major version bumped and so image diffs may be difference * **packages:** Node min version is now 8 * **travis:** drop support for node 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182