fix incorrect stats reported to jest #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anescobar1991
approved these changes
Mar 9, 2021
marcusrbrown
approved these changes
Apr 1, 2021
oneamexbot
added a commit
that referenced
this pull request
Apr 1, 2021
## [4.4.1](v4.4.0...v4.4.1) (2021-04-01) ### Bug Fixes * incorrect stats reported to jest ([#257](#257)) ([e8f949a](e8f949a))
|
🎉 This PR is included in version 4.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
## [4.4.1](americanexpress/jest-image-snapshot@v4.4.0...v4.4.1) (2021-04-01) ### Bug Fixes * incorrect stats reported to jest ([americanexpress#257](americanexpress#257)) ([e8f949a](americanexpress@e8f949a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #243. See that issue for details.
Motivation and Context
When jest finishes, the statistics shown are wrong if some snapshots failed.
How Has This Been Tested?
There are no existing tests that assert on what is reported to jest because
UNSTABLE_SKIP_REPORTINGis enabled.I've tested this manually in a simple project.
Types of Changes
Checklist:
My change requires a change to the documentation and I have updated the documentation accordingly.These changes should be applied to a maintenance branch.I have added the Apache 2.0 license header to any new files created.What is the Impact to Developers Using Jest-Image-Snapshot?
Stats reported to jest are now correct.